Use time_t instead of uint32_t to avoid year 2038 problem. #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paulbearddotname |
fpistm
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
LGTM.
In fact, I think we didn't had this problem as we used uint32_t and no int32_t.
Like time_t is defined as uin32_t it is the same. Anyway, if time_t is changed in the future then it will be compliant.
Note:
now we differ from RTCCZero:
https://github.com/arduino-libraries/RTCZero/blob/9a722372261e822ae418ef8ee60e9f3d8afd6f9f/src/RTCZero.h#L95-L98
ArrestedLightning
pushed a commit
to ArrestedLightning/STM32RTC
that referenced
this pull request
Jan 6, 2023
Be sure to set default value for alarmday, and thus avoid IS_RTC_DATE(day) being false when is not usd in alarm setting Take into account Reset usecase (being able to set new alarma after a reset) Factorize change of RTC clock source in the RTC_begin() function which imply a reset of BackupDomain. Save configuration before this BackupDomain reset, and restore after. fixes stm32duino#82 Signed-off-by: Alexandre Bourdiol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.