Skip to content

https://issues.redhat.com/browse/ACM-19431 #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

jc-berger
Copy link
Collaborator

Copy link

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jc-berger jc-berger self-assigned this Apr 10, 2025
@jc-berger jc-berger merged commit 2fe6d0e into 2.13_stage Apr 14, 2025
1 of 2 checks passed
@jc-berger jc-berger deleted the jcberger-19431-acm-errata-follow-up branch April 14, 2025 15:12
@swopebe
Copy link
Contributor

swopebe commented Apr 14, 2025

@jc-berger:

This appears to have been merged without a peer review. Please get an approval from a peer on all of these, it's best to come to me bc I am in charge of release notes but if I am not able to, another writer can peer review.

For this one, we are using "to be" a lot here, I think we can reduce this: to be unable to be reapplied (reword it to reduce the use to "to be" -- this is a bit confusing).
This relates to the upgrade issue that I documented and I would like to get @jacobbaungard to review this wording, as he is reviewing my release note, as well.
Please check "could" in the modal guidance in the manual. We don't normally use that but I think viewing the standard is worth the effort/knowledge for us. I don't think it is approved but I could be wrong.

@swopebe
Copy link
Contributor

swopebe commented Apr 14, 2025

Also that line with to be is passive, which can also be changed to active voice (as required by IBM Style, though not always possible), please reopen and let me know when you are ready for a peer review. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants