new feature FRAGMENT_FROM_FILE

[BenGardiner]

proposed in #604. This introduces the ability to include 'fragments' of strictdoc files. Dual-purposing [SECTION] as the include target and a section-as-usual didn't seem possible in the grammar and processor.py structure so a [FRAGMENT] top-level directive for include files is proposed here.

[stanislaw]

Thanks a lot for creating this PR. I believe that I have pushed it further to the right direction here: #632. I didn't know how I would open a MR back to your repository, so I simply opened another one here.

I suggest that you rebase your PR on top of the latest main branch, cherry-pick my code review commit and address all (relatively minor) comments. After that, the work should be mergeable.

The resolution of the fragments might need some attention though - it was a result of a quick work by me and the code there could surely be improved. Please check on your side if everything still works like you expect it to work.

[BenGardiner]

Thanks a lot for creating this PR. I believe that I have pushed it further to the right direction here: #632. I didn't know how I would open a MR back to your repository, so I simply opened another one here.

Apologies for that extra work. I'm not sure if I could have prepared the PR differently to enable that. But happy to learn how.

I suggest that you rebase your PR on top of the latest main branch, cherry-pick my code review commit and address all (relatively minor) comments. After that, the work should be mergeable.

No problem -- I can manage all the git backflips necessary

[BenGardiner]

I've addressed all the review feedback here and in #632 .

[stanislaw]

Thanks for doing all this work. I felt like I was almost reviewing my own code 😄

Good catch with the before and after parts when extending the section_contents 👍

Are you planning to push anything on top of this change or should I release a new Pip?

[BenGardiner]

Thanks for doing all this work. I felt like I was almost reviewing my own code 😄

It's my pleasure! Thank you and the team for the strictdoc project!

Are you planning to push anything on top of this change or should I release a new Pip?

Yes, maybe. Depending on discussion #630 ... (we build vcr-experiment from main branch of git for now anyways)