Add support for BACS Debit as a PaymentMethod
#1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
May 29, 2020
| @@ -1025,6 +1025,9 @@ public void setFrontObject(File expandableObject) { | |||
| @Setter | |||
| @EqualsAndHashCode(callSuper = false) | |||
| public static class Settings extends StripeObject { | |||
| @SerializedName("bacs_debit_payments") | |||
| BacsDebitPayments bacsDebitPayments; | |||
There was a problem hiding this comment.
This one doesn't have the Settings prefix because it's nested inside the Settings class as it should. It's the other ones we missed unfortunately and would need to change in a future major
remi-stripe
commented
May 29, 2020
| @@ -184,6 +198,9 @@ public static Mandate retrieve( | |||
| @SerializedName("au_becs_debit") | |||
| AuBecsDebit auBecsDebit; | |||
|
|
|||
| @SerializedName("bacs_debit") | |||
There was a problem hiding this comment.
This should be inside PaymentMethodDetails but... the others are not, so I'll just ignore and we'll fix in a major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for BACS Debit as a
PaymentMethodsettings[bacs_debit_payments]onAccountbacs_debitas atypeonPaymentMethodpayment_method_details[bacs_debit]onChargebacs_debitonMandateCodegen for openapi 7a853ce
r? @cjavilla-stripe
cc @stripe/api-libraries