Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of null expandable attributes #466

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Fix serialization of null expandable attributes #466

merged 2 commits into from
Mar 22, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries @remi-stripe @elenacanovi

Fixes the serialization of expandable attributes when both the ID and the expanded model are null.

Fixes #465.

@brandur-stripe
Copy link
Contributor

LGTM. (Thanks for adding the new test too!)

@ob-stripe ob-stripe merged commit cac38b9 into master Mar 22, 2018
@ob-stripe ob-stripe deleted the ob-fix-465 branch March 22, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brandur-stripe brandur-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @brandur-stripe