Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make product attribute on Plan objects expandable #469

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

ob-stripe
Copy link
Contributor

cc @stripe/api-libraries

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick otherwise LGTM

this.product = product;
public void setProduct(String productID) {
this.product = setExpandableFieldID(productID, this.product);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fixed.

@ob-stripe ob-stripe force-pushed the ob-plan-expand-product branch from 794c73b to e345ac9 Compare March 23, 2018 16:07
@ob-stripe ob-stripe merged commit 5e20ce3 into master Mar 23, 2018
@ob-stripe ob-stripe deleted the ob-plan-expand-product branch March 23, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants