Skip to content

Add support for on_behalf_of attribute on charge objects #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Add support for on_behalf_of attribute on charge objects.

}

public void setOnBehalfOf(String onBehalfOfID) {
this.onBehalfOf = APIResource.setExpandableFieldID(onBehalfOfID, this.destination);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this.destination is used here, can you clarify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste fail -_- Thanks!

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Jun 6, 2018
@ob-stripe ob-stripe merged commit a763d73 into master Jun 6, 2018
@ob-stripe ob-stripe deleted the ob-on-behalf-of branch June 6, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants