Skip to content

Minor fixes #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2018
Merged

Minor fixes #541

merged 7 commits into from
Jun 27, 2018

Conversation

ob-stripe
Copy link
Contributor

A bunch of minor fixes:

  • Remove deprecated exception constructors
  • Make Dispute.getIsChargeRefundable() return a Boolean
  • Remove deserializers from StripeObject.PRETTY_PRINT_GSON
    The correct Gson instance to use when deserializing resources is ApiResource.GSON, this one is used only to serialize resources via toString() or toJson().
  • Remove TODOs about subResourceUrl
    Unfortunately, it's not really possible to use subResourceUrl everywhere because the URLs for nested resources don't map 1:1 with the resource names, e.g. the URL for application fee refunds is /v1/application_fees/:id/refunds and not /v1/application_fees/:id/fee_refunds.
  • Remove deprecated TransferReversalCollection.retrieve(String id, String apiKey) method (missed this one in Remove deprecated methods #532)
  • Remove some unused imports and methods
  • Use lombok's @Cleanup annotation to close resources without having to use try/finally

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn the Cleanup thing is pretty neat

@ob-stripe ob-stripe merged commit 71fe2f2 into integration-v6 Jun 27, 2018
@ob-stripe ob-stripe deleted the ob-fix-todos branch June 27, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants