Add support for Issuing APIs/resources #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
approved these changes
Jul 26, 2018
| objectMap.put("issuing.authorization", com.stripe.model.issuing.Authorization.class); | ||
| objectMap.put("issuing.card", com.stripe.model.issuing.Card.class); | ||
| objectMap.put("issuing.cardholder", com.stripe.model.issuing.Cardholder.class); | ||
| objectMap.put("issuing.card_details", com.stripe.model.issuing.CardDetails.class); |
There was a problem hiding this comment.
At the risk of sounding like a broken record, CardDetails after Card :)
ob-stripe
suggested changes
Jul 26, 2018
| import com.stripe.model.BalanceTransaction; | ||
| import com.stripe.model.ExpandableField; | ||
| import com.stripe.model.MetadataStore; | ||
| import com.stripe.model.HasId; |
There was a problem hiding this comment.
Should be before MetadataStore
| import com.stripe.exception.InvalidRequestException; | ||
| import com.stripe.model.Address; | ||
| import com.stripe.model.MetadataStore; | ||
| import com.stripe.model.HasId; |
| import com.stripe.exception.InvalidRequestException; | ||
| import com.stripe.model.Address; | ||
| import com.stripe.model.MetadataStore; | ||
| import com.stripe.model.HasId; |
| import com.stripe.exception.InvalidRequestException; | ||
| import com.stripe.model.ExpandableField; | ||
| import com.stripe.model.MetadataStore; | ||
| import com.stripe.model.HasId; |
| import com.stripe.model.BalanceTransaction; | ||
| import com.stripe.model.ExpandableField; | ||
| import com.stripe.model.MetadataStore; | ||
| import com.stripe.model.HasId; |
| String city; | ||
| String country; | ||
| String name; | ||
| String network_id; |
| String country; | ||
| String name; | ||
| String network_id; | ||
| String postal_code; |
| .replaceAll("(.)([A-Z][a-z]+)", "$1_$2") | ||
| .replaceAll("([a-z0-9])([A-Z])", "$1_$2") | ||
| .toLowerCase(); | ||
|
|
||
| // Issuing resources are in their own package. Until we can support adding OBJECT_NAME | ||
| // to all classes, we use this dirty trick to properly format the API endpoints | ||
| if(clazz.getName().contains("com.stripe.model.issuing.")) { |
remi-stripe
force-pushed
the
remi-add-issuing
branch
from
0e32a48 to
37592f6
Compare
|
@ob-stripe thank you for catching those! Fixed all of them, PTAL |
ob-stripe
approved these changes
Jul 26, 2018
|
Released as 5.52.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries