Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lombok for StripeCollection #566

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Use Lombok for StripeCollection #566

merged 1 commit into from
Aug 1, 2018

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Aug 1, 2018 •
edited
Loading

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Use Project Lombok for generating StripeCollection accessors.

Also adds the object property to StripeCollection (replaces #564).

I've checked with the Java API Compliance Checker that the new API is 100% compatible with the old one.

@ob-stripe ob-stripe mentioned this pull request Aug 1, 2018
Closed
remi-stripe
remi-stripe approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob-stripe ob-stripe merged commit 01982f9 into master Aug 1, 2018
@ob-stripe ob-stripe deleted the ob-collection-lombok branch August 1, 2018 12:50
@ob-stripe
Copy link
Contributor Author

Released as 6.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ob-stripe @remi-stripe @stripe-ci @brandur-stripe