Add changes related to API version 2018-08-23 #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
reviewed
Aug 27, 2018
| * @deprecated Prefer using the {@code unitAmount} attribute instead. | ||
| * @see <a href="https://stripe.com/docs/upgrades#2018-08-23">API version 2018-08-23</a> | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Is this attribute really deprecated? It's still present in the API reference: https://stripe.com/docs/api#plan_object-amount
There was a problem hiding this comment.
It is actively deprecated since we shipped unit_amount. We're renaming amount because we are going to ship another type of amount property and we wanted to to avoid the confusion.
TL;DR: yep, the docs are incorrect I suppose
|
Can you flag the |
remi-stripe
force-pushed
the
remi-add-2018-08-23-changes
branch
from
f81d8af to
a92d832
Compare
|
@ob-stripe done PTAL |
ob-stripe
reviewed
Aug 28, 2018
| * @deprecated Prefer using the {@link #taxInfo} attribute instead. | ||
| * @see <a href="https://stripe.com/docs/upgrades#2018-08-23">API version 2018-08-23</a> | ||
| */ | ||
| String businessVatId; |
There was a problem hiding this comment.
You need to annotate the attribute itself with @Deprecated.
* add support for `tax_info` and `tax_info_verification` on Customer * add support for `unit_amount` on Tier and deprecate `amount`
remi-stripe
force-pushed
the
remi-add-2018-08-23-changes
branch
2 times, most recently
from
959d817 to
d91c056
Compare
|
@ob-stripe updated, sorry for the back and forth. PTAL |
ob-stripe
approved these changes
Aug 28, 2018
|
Released as 6.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds changes related to the latest API version and new properties introduced
tax_infoandtax_info_verificationon Customerunit_amounton Tier and deprecateamountr? @ob-stripe
cc @stripe/api-libraries