Add support for Review resource #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-radar-review
branch
from
c15756b to
0d6200a
Compare
zanker-stripe
approved these changes
Nov 28, 2018
| import lombok.EqualsAndHashCode; | ||
| import lombok.Getter; | ||
| import lombok.Setter; | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public class Review extends StripeObject implements HasId { | ||
| public class Review extends ApiResource implements HasId { |
There was a problem hiding this comment.
My impression from reading the code, is StripeObject is a basic object wrapper, while ApiResource is a basic object that can be extended to support other APIs like approve in this case. Is that the right way of looking at it?
There was a problem hiding this comment.
Basically, StripeObject == a k/v hash returned by Stripe's API and ApiResource == an actual resource that has API methods (including standard CRUDL methods).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries