Upgrade to Gradle 5.3.1 and fix signing issue #734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @mickjermsurawong-stripe
cc @stripe/api-libraries @hans-stripe
This fixes the signature issue we ran into yesterday. The problem is described in this comment:
We're not using the
com.vanniktech.maven.publish
plugin, but we had the same issue: we manually added thejar
task toconfigurations.archives.artifacts
.After removing the
jar
task fromconfigurations.archives.artifacts
, I've verified that things work as expected:Fixes #733.