Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generated] source: spec3.sdk.yaml@spec-d635d94 in master #744

Merged
merged 2 commits into from
Apr 16, 2019
Merged

[generated] source: spec3.sdk.yaml@spec-d635d94 in master #744

merged 2 commits into from
Apr 16, 2019

Conversation

mickjermsurawong-stripe
Copy link
Contributor

  • This PR contains latest change without the PR on payment intent on invoice.
    r? @remi-stripe

remi-stripe
remi-stripe requested changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the Issuing changes are kind of still being discussed and the reader listing by device_type was never API reviewed and also might not be something we want public

@mickjermsurawong-stripe
Copy link
Contributor Author

@remi-stripe, just to note that spending limits in resource model are not shared between CardHolder/Card which is different from go/.NET

stripe/stripe-dotnet#1576
https://github.com/stripe/stripe-go/pull/831/files

@mickjermsurawong-stripe
Copy link
Contributor Author

The last commit removed device_type, and now has expandable payment intent.

@py-stripe py-stripe self-requested a review April 16, 2019 02:18
@mickjermsurawong-stripe mickjermsurawong-stripe merged commit 01521cc into master Apr 16, 2019
@remi-stripe remi-stripe deleted the mickjermsurawong/sdk-autogen-java-spec-d635d94 branch April 19, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe requested changes

@py-stripe py-stripe py-stripe approved these changes

Assignees

@mickjermsurawong-stripe mickjermsurawong-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickjermsurawong-stripe @remi-stripe @py-stripe @stripe-ci