Support extra parameters in typed params #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow custom strategy within the package * package-level params converter * test create query with encoded param keys * improve comments
mickjermsurawong-stripe
force-pushed
the
mickjermsurawong/extra-params
branch
2 times, most recently
from
9e2c6ce to
b7d90f9
Compare
* [generated] source: spec3.sdk.yaml@spec-6c38dc0 in master * add extra params test on invoice
mickjermsurawong-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply cherry-picked from the integration branch
autogen/servicethat has helpers for adding extra params from this approved PR #752.The motivation is that we want to release extra params separately from the service which isn't finalized yet.
Once this is approved,
r? @ob-stripe
cc @remi-stripe @stripe/api-libraries