Make stripeError transient on StripeException #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, TIL. Sorry for the nit, but mind throwing a comment on there that indicates that the |
|
ptal @ob-stripe |
ob-stripe
force-pushed
the
ob-exception-serializable
branch
from
e7e5639 to
2bdcd1b
Compare
Done! |
brandur-stripe
approved these changes
Aug 30, 2019
|
Released as 11.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Make
stripeErrortransient onStripeException. This ensures thatStripeExceptionis serializable, as it implements theSerializableinterface (all exceptions do) andStripeObjects are not serializable.I briefly considered making
StripeObjects serializable, but it seems like the general consensus is that Java's serialization mechanism is flawed and shouldn't be used in new code (https://stackoverflow.com/a/53889695/5307473) so this is the easiest fix.Fixes #832.