Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate total_count #839

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Deprecate total_count #839

merged 2 commits into from
Sep 3, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Deprecate total_count.

remi-stripe
remi-stripe approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving though shouldn't this be in the autogen instead?

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Sep 3, 2019
@ob-stripe
Copy link
Contributor Author

Approving though shouldn't this be in the autogen instead?

StripeCollection isn't autogenerated.

@stripe-ci stripe-ci removed the approved label Sep 3, 2019
@ob-stripe ob-stripe changed the title Deprecate total_count. Deprecate total_count Sep 3, 2019
@ob-stripe
Copy link
Contributor Author

I pushed a second commit to use the newer onMethod_ syntax that we're already using in autogenerated files, e.g.

stripe-java/src/main/java/com/stripe/model/CustomerBalanceTransaction.java

Line 65 in 4a7a241

@Getter(onMethod_ = {@Override})

@ob-stripe ob-stripe merged commit d2d7b6f into master Sep 3, 2019
@ob-stripe ob-stripe deleted the ob-deprecate-total-count branch September 3, 2019 20:00
@ob-stripe
Copy link
Contributor Author

Released as 11.6.1.

@totof3110 totof3110 mentioned this pull request Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ob-stripe @remi-stripe @stripe-ci