Skip to content

Codegen for openapi 4d4a107 #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2019
Merged

Codegen for openapi 4d4a107 #850

merged 4 commits into from
Sep 27, 2019

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Sep 27, 2019 •
edited
Loading

  • Add support for mandate on Charge.
  • Add support for reference on SourceTransaction.
  • Add support for person on `TokenCreateParams
  • Add support for new event types payment_intent.canceled and setup_intent.canceled
  • Add support for metadata on AuthorizationApproveParams and AuthorizationDeclineParams
  • Add setMetadata method on AuthorizationUpdateParams
  • Rename "chidrens_and_infants_wear_stores" to "childrens_and_infants_wear_stores". This is technically a breaking change, but we've chosen to release this as a minor version as the previous name was virtually unused.

@richardm-stripe richardm-stripe mentioned this pull request Sep 27, 2019
Closed
@ob-stripe ob-stripe changed the title Codegen for openapi 6efec10 [wip] Codegen for openapi 6efec10 Sep 27, 2019
@ob-stripe
Copy link
Contributor

Tagged as WIP to avoid merging while we fix the OpenAPI spec.

@richardm-stripe
Copy link
Contributor Author

Changes that should not be in here:
-CardholderCreateParams.authorizationControls
-CardholderUpdateParams.authorizationControls
-CardCreateParams.authorizationControls
-CardUpdateParams.authorizationControls

Changes that belong:
+TokenCreateParams.person

+CardUpdateParams.setMetadata(EmptyParam)
+CardUpdateParams.setMetadata(Map<String, String>)
+TransactionUpdateParams.setMetadata(EmptyParam)
+TransactionUpdateParams.setMetadata(Map<String, String>)
+AuthorizationApproveParams.setMetadata(EmptyParam)
+AuthorizationApproveParams.setMetadata(Map<String, String>)
+AuthorizationDeclineParams.setMetadata(EmptyParam)
+AuthorizationDeclineParams.setMetadata(Map<String, String>)
+AuthorizationUpdateParams.setMetadata(EmptyParam)
+AuthorizationUpdateParams.setMetadata(Map<String, String>)

@richardm-stripe richardm-stripe changed the title [wip] Codegen for openapi 6efec10 [wip] Codegen for openapi 4d4a107 Sep 27, 2019
@ob-stripe
Copy link
Contributor

LGTM, but assigning to @remi-stripe for another pair of 👀

remi-stripe
remi-stripe approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the issues in the autogen!

src/main/java/com/stripe/model/Charge.java

/** ID of the mandate used to make this payment. */
@SerializedName("mandate")
String mandate;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in theory should be gated but I won't fight over this

src/main/java/com/stripe/param/issuing/CardCreateParams.java
@SerializedName("child_care_services")
CHILD_CARE_SERVICES("child_care_services"),

@SerializedName("childrens_and_infants_wear_stores")
CHILDRENS_AND_INFANTS_WEAR_STORES("childrens_and_infants_wear_stores"),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAke sure to mention this as a "breaking" change

@richardm-stripe richardm-stripe changed the title [wip] Codegen for openapi 4d4a107 Codegen for openapi 4d4a107 Sep 27, 2019
@richardm-stripe richardm-stripe merged commit 9c8e6d1 into master Sep 27, 2019
@richardm-stripe richardm-stripe deleted the richardm/codegen-6efec10 branch September 27, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardm-stripe @ob-stripe @remi-stripe @stripe-ci