Skip to content

Fix flow removal by taking advantage of 'flow' option #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix flow removal by taking advantage of 'flow' option #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d5e037
Fix flow removal by taking advantage of 'flow' option
detrohutt Mar 22, 2018
7d7c614
Revert changes to rewirePreset.js in favor of backwards compatibility
detrohutt Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rewireWebpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ const rewireTypescript = config => {

// Replace the babel-preset-react-app preset with the preset rewire from this
// package. This is done so @babel/preset-flow can be removed.
babelLoader.options.presets = [path.resolve(__dirname, "rewirePreset")];
babelLoader.options.presets = [
[path.resolve(__dirname, "rewirePreset"), { flow: false }]
];

// Replace the preset in the SVG loader for the same reason as above.
const svgLoader = getLoader(config.module.rules, svgLoaderMatcher);
Expand Down