Fix #350 - Strip styled components referenced in css by not used in the render #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-hurst-cmd
force-pushed
the
master
branch
from
54d0d7c to
fa4947e
Compare
robert-hurst-cmd
force-pushed
the
master
branch
from
fa4947e to
38419c2
Compare
|
@MicheleBertoli Let me know what you think once you're able to check this one out. Any changes needed, I'm happy to make them. |
|
Any update, this change would resolve our issue with jest introducing unnecessary css |
|
@probablyup any chance we can merge this? This would clear up some CI frustrations for us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes CSS rules referencing unused styled components from the snapshot. See #350 for details.
The approach I took here was adding a filter for CSS rules which contain references to unknown styled component class names.
Note that this also fixes a test; "referring to other components", which was incorrectly passing, as it contained a reference to a container element that was never used.