Remove sc style nodes on cleanup #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exah
approved these changes
Jul 12, 2021
quantizor
approved these changes
Jul 12, 2021
atsikov
force-pushed
the
sc-nodes-cleanup
branch
from
8949400 to
3e8d4ce
Compare
|
@probablyup done, added a test |
quantizor
approved these changes
Jul 12, 2021
|
@probablyup any plans to release this change? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cleanup,
jest-styled-componentsresetsstyled-componentsinternal state, but leaves styles in document head. This leads to significant jsdom performance degradation in large tests.This PR improves cleanup, so that
style[data-styled-version]nodes are removed from the document.