Added #9 largest-non-adjacent-sum #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeni-dev
suggested changes
Jan 15, 2019
|
|
||
| DP[0] = array[0] | ||
| DP[1] = max(array[0] , array[1]) | ||
|
|
There was a problem hiding this comment.
and also it fails when len(array)==0.
| def maximumNonAdjacentSum(array): | ||
|
|
||
| DP = [0]*len(array) | ||
|
|
There was a problem hiding this comment.
space is O(n). It is not a constant space. If you look closely on the algorithm, you are using only three at any instance, DP_i, DP_i_1, DP_i_2. You can rewrite the alogithm to do that
seeni-dev
reviewed
Jan 15, 2019
| for i in range(2,len(array)): | ||
|
|
||
| DP[i] = max3( array[i] , array[i] + DP[i-2] , DP[i-1]) | ||
| print(DP) |
There was a problem hiding this comment.
as pointed out above rewrite this line to use constant space
Open
|
Will make the necessary changes and raise a new PR again. Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
largest-non-adjacent-sum was solved using Dynamic Programming approach.