Skip to content

Commit bb368d6

Browse files
authored
General Improvements (actions#70)
# General Improvements > This is a classic @GrantBirki drive-by PR 🚗 This pull request does the following: - Lightly updates and formats a few existing Actions workflows - Adds a new `package-check` workflow to validate the contents of the `dist/` directory have been properly built - Uses a `.node-version` file so that local development and Actions remain on the same pinned version of node - Adds status badges to the readme for visual effect ⭐ 🎨
1 parent eaddb9e commit bb368d6

File tree

7 files changed

+43
-9
lines changed

7 files changed

+43
-9
lines changed

Diff for: .github/workflows/release.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
name: release
2-
"on":
2+
3+
on:
34
push:
45
branches:
56
- main
@@ -18,10 +19,12 @@ jobs:
1819
- uses: actions/checkout@v4
1920
with:
2021
persist-credentials: false
22+
2123
- uses: actions/setup-node@v4
2224
with:
23-
node-version: 20
24-
cache: "npm"
25+
node-version-file: .node-version
26+
cache: 'npm'
27+
2528
- run: npm ci
2629
- run: npm run build
2730
- uses: ./

Diff for: .github/workflows/test.yml

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
name: test
2+
23
on:
34
push:
45
branches:
@@ -15,10 +16,12 @@ jobs:
1516
runs-on: ubuntu-latest
1617
steps:
1718
- uses: actions/checkout@v4
19+
1820
- uses: actions/setup-node@v4
1921
with:
20-
node-version: 20
21-
cache: "npm"
22+
node-version-file: .node-version
23+
cache: 'npm'
24+
2225
- run: npm ci
2326
- run: npm test
2427

Diff for: .node-version

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
20.0.0

Diff for: README.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Create GitHub App Token
22

3+
[![test](https://github.com/actions/create-github-app-token/actions/workflows/test.yml/badge.svg)](https://github.com/actions/create-github-app-token/actions/workflows/test.yml)
4+
35
GitHub Action for creating a GitHub App installation access token.
46

57
## Usage
@@ -46,7 +48,7 @@ jobs:
4648
# required
4749
app-id: ${{ vars.APP_ID }}
4850
private-key: ${{ secrets.PRIVATE_KEY }}
49-
- uses: actions/checkout@v3
51+
- uses: actions/checkout@v4
5052
with:
5153
token: ${{ steps.app-token.outputs.token }}
5254
ref: ${{ github.head_ref }}

Diff for: badges/coverage.svg

+25
Loading

Diff for: package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"version": "1.5.1",
66
"description": "GitHub Action for creating a GitHub App Installation Access Token",
77
"scripts": {
8-
"build": "esbuild main.js post.js --bundle --outdir=dist --out-extension:.js=.cjs --platform=node --target=node16.16",
8+
"build": "esbuild main.js post.js --bundle --outdir=dist --out-extension:.js=.cjs --platform=node --target=node20.0.0",
99
"test": "c8 --100 ava tests/index.js",
1010
"coverage": "c8 report --reporter html",
1111
"postcoverage": "open-cli coverage/index.html"

0 commit comments

Comments
 (0)