Skip to content

Language and Documentation Improvements #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Language and Documentation Improvements #856

wants to merge 3 commits into from

Conversation

mellkior
Copy link

@mellkior mellkior commented Apr 8, 2025

Changed

Frontend

  • 🌐 The link sharing visibility options were "Reading" and "Edition". Edition is not the correct word to use in this situation, I changed it to "Editing" for parallelism with "Reading". Another reasonable and arguably more natural option (for English) would be to change "Reading" to "Viewer" and "Edition" to "Editor", however, "Reading" and "Editing" are correct.
    Screenshot from 2025-04-07 21-57-44

Documentation

  • ✏️ The --signoff option was misspelled as --sign-off in CONTRIBUTING.md, I fixed it.
  • 📝 The https://gitmoji.dev/ link in CONTRIBUTING.md was not using standard markdown link syntax, I updated it.

mellkior added 3 commits April 7, 2025 21:47
@mellkior
🌐(frontend) update visibility label
8efc673 
Update "Edition" to "Editing" in document sharing interface.

Signed-off-by: mellkior <[email protected]>
@mellkior
✏️(docs) fix --signoff option
56df67a 
Remove the hypen ("-") from `git commit --sign-off`.

Signed-off-by: mellkior <[email protected]>
@mellkior
📝(docs) improve link in markdown
9e3fcec 
Use standard markdown syntax for the gitmoji.dev link.

Signed-off-by: mellkior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mellkior