Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for SELECT .. ORDER BY ... #102

Merged
merged 2 commits into from
Jan 25, 2024
Merged

add support for SELECT .. ORDER BY ... #102

merged 2 commits into from
Jan 25, 2024

Conversation

mobley-trent
Copy link
Contributor

#51

psteinroe
psteinroe requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already supported. See failing test. It's part of the sort by node.

@mobley-trent
Copy link
Contributor Author

It didn't seem to be supported with the SELECT statement though. I ran the test initially and the token vector returned by the testing function only had the SELECT and FROM tokens, the ORDER and BY tokens were not returned.

@psteinroe
Copy link
Collaborator

Yes, because the tokens are not supposed to be part of the SelectStmt node. If you instead pass the SortBy node to the test function it will return the tokens. Or just add a select with order by to the e2e test. It will pass.

@psteinroe psteinroe marked this pull request as ready for review January 25, 2024 07:45
@psteinroe psteinroe merged commit 7485116 into supabase-community:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinroe psteinroe psteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobley-trent @psteinroe