Skip to content

chore: improve logs #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 3, 2025
Merged

chore: improve logs #266

merged 16 commits into from
Apr 3, 2025

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Mar 29, 2025 •
edited
Loading

  1. Adds a configurable bunyan log format (default is still hierarchical), configurable via PGT_LOG_KIND env var
  2. Adds timestamps to hierarchical log format
  3. Makes log level configurable via PGT_LOG_LEVEL env var, default stays the same
  4. Cleans up log journey by removing logged fields that we do not use at runtime

@juleswritescode
Copy link
Collaborator Author

@psteinroe The default log level is now info – if we ask issue reporters to copy their log files, maybe the default should be debug. wdyt?

psteinroe
psteinroe approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the flexibility!

@psteinroe psteinroe merged commit e869302 into main Apr 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinroe psteinroe psteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juleswritescode @psteinroe