feat: support "create view" with relpersistence

[cvng]

What kind of change does this PR introduce?

Follow-up for #63, #51

What is the current behavior?

Parser panics

What is the new behavior?

Parser returns:

        ViewStmt(
            ViewStmt {
                view: Some(
                    RangeVar {
                        catalogname: "",
                        schemaname: "",
                        relname: "comedies",
                        inh: true,
                        relpersistence: "t",
                        alias: None,
                        location: 33,
                    },
                ),
                aliases: [],
                query: Some(
                    Node {
                        node: Some(
                            SelectStmt(
                                SelectStmt {
                                    distinct_clause: [],
                                    into_clause: None,
                                    target_list: [
                                        Node {
                                            node: Some(
                                                ResTarget(
                                                    ResTarget {
                                                        name: "",
                                                        indirection: [],
                                                        val: Some(
                                                            Node {
                                                                node: Some(
                                                                    ColumnRef(
                                                                        ColumnRef {
                                                                            fields: [
                                                                                Node {
                                                                                    node: Some(
                                                                                        AStar(
                                                                                            AStar,
                                                                                        ),
                                                                                    ),
                                                                                },
                                                                            ],
                                                                            location: 52,
                                                                        },
                                                                    ),
                                                                ),
                                                            },
                                                        ),
                                                        location: 52,
                                                    },
                                                ),
                                            ),
                                        },
                                    ],
                                    from_clause: [
                                        Node {
                                            node: Some(
                                                RangeVar(
                                                    RangeVar {
                                                        catalogname: "",
                                                        schemaname: "",
                                                        relname: "films",
                                                        inh: true,
                                                        relpersistence: "p",
                                                        alias: None,
                                                        location: 59,
                                                    },
                                                ),
                                            ),
                                        },
                                    ],
                                    where_clause: None,
                                    group_clause: [],
                                    group_distinct: false,
                                    having_clause: None,
                                    window_clause: [],
                                    values_lists: [],
                                    sort_clause: [],
                                    limit_offset: None,
                                    limit_count: None,
                                    limit_option: Default,
                                    locking_clause: [],
                                    with_clause: None,
                                    op: SetopNone,
                                    all: false,
                                    larg: None,
                                    rarg: None,
                                },
                            ),
                        ),
                    },
                ),
                replace: true,
                options: [],
                with_check_option: NoCheckOption,
            },
        ),

Additional context

I would expect Temporary token to be part of RangeVar node but parser still panics so I had to make it part of ViewStmt, very similar to what we had with the As token being part of CreateDomainStmt in #61

[cvng]

Here, I would expect Temporary token to be part of RangeVar node but parser still panics so I had to make it part of ViewStmt, very similar to what we had with the As token being part of CreateDomainStmt in #61

cc @psteinroe

[psteinroe]

thats an interesting case! I agree with your reasoning. to give a bit of context. Take the substring create temporary view comedies as an example. The create and the view token should be part of the ViewStmt itself, while the temporary is definitely part of the RangeVar node. We cannot create a valid tree out of this, since we would have to open RangeVar at temporary, close it to go back to ViewStmt and then open it again to be back at RangeVar for comedies. So yes, we should pull temporary back up into ViewStmt. thanks!

[cvng]

it makes sense, thanks for the clarification

[psteinroe]

btw @cvng feel free to add your sample statements do tests/data/statements/valid to also include them in the e2e tests!

[cvng]

btw @cvng feel free to add your sample statements do tests/data/statements/valid to also include them in the e2e tests!

I will do, I find it generally more convenient to debug at the e2e layer