Skip to content

minor fixes for easier contrib #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

cvng
Copy link
Contributor

@cvng cvng commented Dec 12, 2023

What kind of change does this PR introduce?

Fixes various warnings encountered when trying to run the project

What is the current behavior?

  • testing requires cargo +nightly test
  • warnings with cargo check
  • parser lib cannot be used a dependencies (proto file path is relative)

What is the new behavior?

  • testing with cargo test
  • no warnings
  • parser lib can be used a dependencies

Additional context

This PR can be split into multiple PRs if you see fit @psteinroe

@@ -32,3 +33,12 @@ pub fn parser_mod(_item: proc_macro2::TokenStream) -> proc_macro2::TokenStream {
#get_nodes
}
}

fn proto_file_path() -> path::PathBuf {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ♥️

@psteinroe psteinroe merged commit 447e429 into supabase-community:main Dec 12, 2023
@cvng cvng deleted the minor-fixes branch December 12, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants