fix: location and add support for create publication #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
commented
Dec 21, 2023
Comment on lines
+58
to
+73
| NodeEnum::PublicationObjSpec(n) => { | ||
| match &n.pubtable { | ||
| Some(pubtable) => match &pubtable.relation { | ||
| Some(range_var) => Some(range_var.location), | ||
| None => Some(n.location), | ||
| }, | ||
| None => Some(n.location), | ||
| } | ||
| }, | ||
| NodeEnum::BooleanTest(n) => { | ||
| if n.arg.is_some() { | ||
| get_location_internal(&n.arg.as_ref().unwrap().node.as_ref().unwrap()) | ||
| } else { | ||
| Some(n.location) | ||
| } | ||
| }, |
There was a problem hiding this comment.
@cvng fixed location here
psteinroe
commented
Dec 21, 2023
Comment on lines
+706
to
+732
| if let Some(n) = n.pubobjects.first() { | ||
| tokens.push(TokenProperty::from(Token::For)); | ||
| if let Some(NodeEnum::PublicationObjSpec(n)) = &n.node { | ||
| match n.pubobjtype() { | ||
| protobuf::PublicationObjSpecType::PublicationobjTable => { | ||
| tokens.push(TokenProperty::from(Token::Table)); | ||
| }, | ||
| protobuf::PublicationObjSpecType::PublicationobjTablesInSchema => { | ||
| tokens.push(TokenProperty::from(Token::Tables)); | ||
| tokens.push(TokenProperty::from(Token::InP)); | ||
| tokens.push(TokenProperty::from(Token::Schema)); | ||
| }, | ||
| _ => panic!("Unknown CreatePublicationStmt {:#?}", n.pubobjtype()) | ||
| } | ||
| } | ||
| } | ||
| if let Some(n) = n.pubobjects.last() { | ||
| if let Some(NodeEnum::PublicationObjSpec(n)) = &n.node { | ||
| match n.pubobjtype() { | ||
| protobuf::PublicationObjSpecType::PublicationobjTablesInSchema => { | ||
| tokens.push(TokenProperty::from(Token::Tables)); | ||
| tokens.push(TokenProperty::from(Token::InP)); | ||
| tokens.push(TokenProperty::from(Token::Schema)); | ||
| }, | ||
| _ => {} | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this can be implemented safer. we should do .find() for all types and add the respective tokens if at least one can be found. feel free to fix this @cvng
There was a problem hiding this comment.
sure, let's have this in a next PR with a test_create_publication test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #92