feat: support create conversion
#97
Merged
+166
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Support create conversion, chip away at #51
What is the current behavior?
LSP quits with exit code 101 upon attempting to parse
create conversion
LSP Log
What is the new behavior?
Handles
create conversion
queriesAdditional context
Is there a file naming convention for the tests in
crates/parser/tests/data/statements
? I see some gaps in the numbers, but I couldn't identify a pattern so I just added a new test at the end.Also, not sure if checking for
n.func_name.len() > 0
is the best approach for handling adding theFrom
token, as I don't understand whyfunc_name
is aList*
. Not sure when it would ever not be 0 or 1, would seriously appreciate some insight :)Awesome project, thx so much for the work!