Add Filter Semantic Improvements #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GRSouza @satishbabariya I moved the PR into this repo. |
grdsdev
approved these changes
Sep 6, 2021
|
@GRSouza approved the changes, what is left todo to get this merge-ready? |
|
@satishbabariya would you like to take a look on this or I can merge it? |
@GRSouza, sure no conflicting api's, we can merge it. also we need to start work on https://github.com/supabase/supabase-js/blob/master/src/lib/SupabaseRealtimeClient.ts and RPC stuff that is remain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See old PR
Issue
Issue Link
What kind of change does this PR introduce?
This PR introduces semantics updates for PostgrestFilterBuilder
What is the current behavior?
Same for many other operators.
What is the new behavior?
Additional context
The idea is to improve semantics by providing descriptive function names. These are implemented as an extension to PostgrestFilterBuilder, which allows to keep the existing function names (aka the mirrors of the JS library).