Add return=minimal option, Fix content-type bug #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for the contribution. Can you rebase this PR for getting rid of the other commits? I can merge it after that. |
author Khan Winter <[email protected]> 1627658421 -0500 committer Khan Winter <[email protected]> 1638459904 -0600 Fixed RPC builder, removed testing framework Fixed a bug with the RPC builder setting the query builder's method to the RPC's schema. Added a test for RPC functions. Removed unnecessary testing framework. Updated README.md Add Test for RPC function call Fix RPC builder bug RPC builder was passing `schema` to the `method` property. Rename `form` to `from` Update PostgrestBuilder.swift Make body content-type explicit Make body content-type explicit Actually make content-type explicit for JSON httpbody Update PostgrestFilterBuilder.swift Add return= option Adds an enum `PostgrestReturningOptions` that specifies either a `minimal` or `representation` return from the PostgREST query. This option is added to `insert`, `update`, and `delete`. In relation to issue supabase-community#18
|
Should be ready to merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR Change
content-type=application/jsonheader when necessary toPostgrestBuilder.returns=minimaloption suggested in Provide parameter „returning:minimal“ for Swift #18 to optionally not return any option when inserting, updating, or deleting data.PostgrestReturningOptionsfor how to specify this option.