Skip to content

Fix crash and httpBody not being set #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2021
Merged

Fix crash and httpBody not being set #4

merged 3 commits into from
Jul 31, 2021

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Jul 29, 2021

Changes

  • This PR chages the unowned self to a weak self inside the execute method as isn't guaranteed that the PostgresBuilder class will still be alive when the response returns.
  • The httpBody wasn't being set when building the request.

@satishbabariya satishbabariya self-assigned this Jul 31, 2021
@satishbabariya satishbabariya merged commit c179942 into supabase-community:master Jul 31, 2021
thecoolwinter added a commit to thecoolwinter/postgrest-swift that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants