feat: add maxResultSize limit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
commented
Mar 25, 2025
Comment on lines
+117
to
+140
| // Check the result size if maxResultSize is configured | ||
| if (self._maxResultSize) { | ||
| // Calculate result size (rough approximation) | ||
| let resultSize = 0 | ||
|
|
||
| // For multiple result sets | ||
| if (results.length > 1) { | ||
| for (let i = 0; i < rows.length; i++) { | ||
| resultSize += self._calculateResultSize(rows[i]) | ||
| } | ||
| } else if (rows.length > 0) { | ||
| resultSize = self._calculateResultSize(rows) | ||
| } | ||
|
|
||
| // If the size limit is exceeded, generate an error | ||
| if (resultSize > self._maxResultSize) { | ||
| const error = new Error('Query result size exceeded the configured limit') | ||
| error.code = 'RESULT_SIZE_EXCEEDED' | ||
| error.resultSize = resultSize | ||
| error.maxResultSize = self._maxResultSize | ||
| return self.handleError(error) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
note
The native code shouldn't really be called in our case, it's there because it needs to be handled to work with the main repo tests.
soedirgo
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Main PR can be found here: brianc#3406