feat: bringing postgres package into our package set #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashkinelfe
reviewed
Sep 12, 2024
| "--sysconfdir=/etc" | ||
| "--libdir=$(lib)/lib" | ||
| "--with-system-tzdata=${tzdata}/share/zoneinfo" | ||
| "--enable-debug" |
There was a problem hiding this comment.
I'd drop --enable-debug and use CFLAGS=-g3 instead like in fdaee4b
As per
https://wiki.postgresql.org/wiki/Developer_FAQ --enable-debug will also set less speed-optimal optimization i.e. -Og CFLAGS (and also -fno-omit-frame-pointer) that could decrease performance compared to default -02. I think for production system -g3 is better
There was a problem hiding this comment.
@pashkinelfe ok I will try that thanks!
There was a problem hiding this comment.
@pashkinelfe I am going to do this for sure, but going to isolate it to another PR so that we can keep the rest of this work moving forward, and so that I can assure that we build a separateDebugInfo with this outcome too.
olirice
approved these changes
Sep 12, 2024
darora
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces the following changes
nix flake check -LThe version of postgresql for 15 remains unchanged here, and no other major version is yet introduced. This change also does not update the version of nixpkgs used. Those changes will come in subsequent pull requests.