feat: advance to ubuntu 24.04 #1416
Conversation
|
next step is to test this in local infra setups. @pcnc would love to collaborate with you on what should be tested here. |
samrose
force-pushed
the
sam/ubuntu-24-04
branch
from
b402cac to
623f9cd
Compare
samrose
changed the title
samrose
force-pushed
the
sam/ubuntu-24-04
branch
from
623f9cd to
9259588
Compare
samrose
force-pushed
the
sam/ubuntu-24-04
branch
from
9975d5b to
2d6bd69
Compare
Thanks @tgallacher yes this definitely won't be merged until run through local infra testing scenarios. We should use incremental rollout when deployed too. |
|
Just minor observation, it seems that postgres/nix/tools/update_readme.nu Line 156 in e88ce4b |
samrose
force-pushed
the
sam/ubuntu-24-04
branch
from
22e96b4 to
be81efa
Compare
resolve thanks! |
samrose
force-pushed
the
sam/ubuntu-24-04
branch
from
73bff06 to
6f5d30c
Compare
| @@ -141,7 +141,7 @@ jobs: | |||
| - name: Upload nix flake revision to s3 prod | |||
| run: | | |||
| aws s3 cp /tmp/pg_binaries.tar.gz s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/20.04.tar.gz | |||
| aws s3 cp /tmp/pg_binaries.tar.gz s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/24.04.tar.gz | |||
There was a problem hiding this comment.
Can these version changes be deduplicated?
There was a problem hiding this comment.
@steve-chavez we can certainly address this. But as @pcnc had discussed in slack thread, these are currently tied to infrastructure functionality. So, instead of trying to make those changes as a part of the upgrade to ubuntu 24.04 PR, let's create another PR where we can introduce those changes and test and make sure nothing else breaks. We should not try to accomplish that in this PR.
| @@ -113,7 +113,7 @@ jobs: | |||
|
|
|||
| - name: Upload pg_upgrade scripts to s3 prod | |||
| run: | | |||
| aws s3 cp /tmp/pg_upgrade_bin.tar.gz s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/20.04.tar.gz | |||
| aws s3 cp /tmp/pg_upgrade_bin.tar.gz s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/24.04.tar.gz | |||
There was a problem hiding this comment.
Ditto. Deduplication is needed.
There was a problem hiding this comment.
yes, agree we should address this. As stated above, as @pcnc had discussed in slack thread, these are currently tied to infrastructure functionality. So, instead of trying to make those changes as a part of the upgrade to ubuntu 24.04 PR, let's create another PR where we can introduce those changes and test and make sure nothing else breaks. We should not try to accomplish that in this PR.
Co-authored-by: Div Arora <[email protected]>
... rather than the traditional dhclient.conf approach.
samrose
force-pushed
the
sam/ubuntu-24-04
branch
from
6f5d30c to
be3a961
Compare
|
working on retest of this branch, and then should be ready to put into staging |
What kind of change does this PR introduce?