feat: add test for security definer functions #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darora
approved these changes
Feb 24, 2025
|
@staaldraad I am re-running the failed testinfra test, as it appears to have just been a connectivity issue on that. Once it passes, I'll add an approval on this one. Thank you! |
|
@staaldraad all checks passing! |
samrose
approved these changes
Feb 24, 2025
|
Maybe also prefix the function names with schema name to make it absolutely clear which function are security definers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
test
What is the new behavior?
Adds security / regression checks to ensure new security definer functions aren't introduced without first being vetted.
Additional context
Checks all extensions installed, if a new extension is added, it should be present in prime.sql. If a new security definer function is introduced, it must be vetted and if safe, added to the output in security.out
Fixes SEC-204