add migration for pg_create_subscription grant #1514
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
reviewed
Apr 3, 2025
migrations/db/migrations/20250402093753_grant_subscription_to_postgres_16_and_above.sql
Outdated
Show resolved
Hide resolved
…postgres_16_and_above.sql
soedirgo
approved these changes
Apr 3, 2025
|
Please let's merge #1521 before this one. We're adding new tests and we need to ensure this one is passing. (I can help to modify tests if something fails here). |
soedirgo
requested changes
Apr 4, 2025
|
#1521 was merged, please rebase here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Non superusers are unable to create subscriptions
What is the new behavior?
For 16 and above, this is possible as long as
pg_create_subscriptionis granted by superuser to a roleAdditional context
Unsure if handling the version check in the migration is the best choice but it is the most automated way