fix: skip installing ndisc issue resolver in qemu mode #1519
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was caused by very frequent RAs in ec2 when operating in IPv6 mode. The qemu artifact gets configured with a static IP instead, so this service should no longer be needed. Additionally, fixes the build process to correctly define qemu_mode for both ansible calls.
darora
commented
Apr 3, 2025
ansible/files/adminapi.service.j2
Outdated
| @@ -8,6 +8,9 @@ User=adminapi | |||
| Restart=always | |||
| RestartSec=3 | |||
| Environment="AWS_USE_DUALSTACK_ENDPOINT=true" | |||
| {% if qemu_mode is defined and qemu_mode is True %} | |||
There was a problem hiding this comment.
I think this should work?
thebengeu
approved these changes
Apr 3, 2025
darora
force-pushed
the
da/remove-additional-pkg
branch
2 times, most recently
from
afa4f75 to
1e63ed9
Compare
darora
force-pushed
the
da/remove-additional-pkg
branch
from
1e63ed9 to
809cfa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by very frequent RAs in ec2 when operating in
IPv6 mode. The qemu artifact gets configured with a static IP instead,
so this service should no longer be needed.
Additionally, fixes the build process to correctly define qemu_mode
for both ansible calls.
Also ports over a change from our init code for adminapi config loading.