fix: patch pgmq using Nix instead of supautils custom scripts #1531
+119
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just to prove the test failure. Essentially the `drop_queue` is not patched to remove the partitioned argument: - pgmq | pgmq | drop_queue | queue_name text > + pgmq | pgmq | drop_queue | queue_name text, partitioned boolean >
steve-chavez
changed the title
steve-chavez
changed the title
samrose
reviewed
Apr 8, 2025
soedirgo
requested changes
Apr 9, 2025
There was a problem hiding this comment.
Hold off for now - there's still some discussion on this internally
|
This is now fixed on supautils itself, see supabase/supautils#134 I've left #1533 open in case we want to reconsider moving patches to Nix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to prove the test failure when the patch is not applied. Essentially the
drop_queueis not patched to remove the partitioned argument:See failure on https://github.com/supabase/postgres/actions/runs/14321609982/job/40139470008
Reapplies the patch. Uses Nix to patch the pgmq extension instead of supautils custom scripts. Gets the tests passing again.