Skip to content

feat: do not enable pgjwt by default in pg 15 #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2025
Merged

Conversation

samrose
Copy link
Collaborator

@samrose samrose commented May 12, 2025

What kind of change does this PR introduce?

Going forward we will not enable pgjwt by default in postgres 15.x

@samrose samrose requested review from a team as code owners May 12, 2025 19:16
Comment on lines 37 to 43
- name: Remove pgjwt from supautils.conf if 15 build
ansible.builtin.command:
cmd: >
sed -i 's/ pgjwt,//g'
/etc/postgresql-custom/supautils.conf
when: is_psql_15 and stage2_nix
become: yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Can this be tried locally?

If not, we're planning to remove ansible later right?

Copy link
Collaborator Author

@samrose samrose May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steve-chavez yes we are planning to remove ansible later. This can be tried locally, and will be part of our local testing env I'll add a change for that in this PR.

I am starting with the auth project to migrate package and config steps out of ansible. Then likely postgres will be next, fwiw.

@samrose samrose requested a review from a team as a code owner May 15, 2025 19:37
@delgado3d delgado3d merged commit fcb876d into develop May 17, 2025
14 checks passed
@delgado3d delgado3d deleted the sam/pg15pgjwt branch May 17, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants