Skip to content

chore: bump wrappers version to v0.5.1 #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

burmecia
Copy link
Member

What kind of change does this PR introduce?

  • upgrade wrappers from v0.5.0 to v0.5.1

Additional context

  • The major change in this version is added a new Iceberg FDW
  • Rust version >= 1.85.1 is required
  • The ClickHouse FDW upstream is changed to a forked repo https://github.com/burmecia/clickhouse-rs.git and branch is supabase-patch
  • The Iceberg FDW upstream hasn't release the latest version yet, so we use its git repo as dependency

Action Items

  • New extension releases were Checked for any breaking changes
  • Extensions compatibility Checked
  • Backup and Restore Checked
    • Proceed to backup testing while extensions are enabled
      • After every restore, re-run the tests specified at point 3.1

Extensions compatibility testing

  1. Enable every extension
    1. Check Postgres’ log output for any error messages while doing so
      1. This might unearth incompatibilities due to unsupported internal functions, missing libraries, or missing permissions
  2. Disable every extension
    1. Check Postgres’ log output for any cleanup-related error messages
  3. Re-enable each extension
    1. Run basic tests against the features they offer, e.g.:
      1. pg_net - execute HTTP requests
      2. pg_graphql - execute queries and mutations
      3. …to be filled in

Backup Testing

Follow the testing steps steps for all the following cases:

  • Pause on new Postgres version, restore on new Postgres version
  • Pause on older Postgres version, restore on new Postgres version
  • Run a single-file backup backup, restore the backup

Testing steps

  1. Generate dummy data
    • the ‘Countries’ or ‘Slack clone’ SQL editor snippets are decent datasets to work with, albeit limited
  2. Save a db stats snapshot file
    • Do this by running supa db-stats gather -p <project_ref>
  3. Backup the database, through pausing the project, or otherwise
  4. Restore the backup, through unpausing the project or cli
  5. Check the data has been recovered successfully
    1. Visual checks/navigating through the tables works
    2. Run supa db-stats verify against the project and the previously saved file

@burmecia burmecia requested review from a team as code owners May 26, 2025 06:15
@soedirgo
Copy link
Member

soedirgo commented May 28, 2025

Checks are failing:

       > Caused by:
       >   feature `edition2024` is required
       >
       >   The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.76.0).
       >   Consider adding `cargo-features = ["edition2024"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.
       >   See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.

iceberg 0.5.0 requires edition2024

@samrose
Copy link
Collaborator

samrose commented May 28, 2025

@soedirgo I am working on finding the issue with Rust handling that is causing this breakage. I am hoping to have it resolved within a day or two.

@burmecia
Copy link
Member Author

burmecia commented Jun 3, 2025

@samrose , FYI I've raised a PR to add rust 1.85.1 + pgrx 0.14.3. With that PR the new package cargo-pgrx_0_14_3 can build successfully, but still got some errors when build Wrappers. Most likely related to this 2 dependencies:

I will take further investigation on that.

version = "0.14.3";
hash = "sha256-3TsNpEqNm3Uol5XPW1i0XEbP2fF2+RKB2d7lO6BDnvQ=";
cargoHash = "sha256-Ny7j56pwB+2eEK62X0nWfFKQy5fBz+Q1oyvecivxLkk=";
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the above, so the build will break due to this duplicate

@samrose
Copy link
Collaborator

samrose commented Jun 5, 2025

Somehow the nixpkgs input in flake.lock got updated, which we don't want to currently. I rolled it back to what is in the develop branch locally. I am trying to see if I can refactor the cargo-pgrx, buildPgrx and pacakges that use buildPgrx to properly respect the specified Rust version per package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants