feat: delegated-init support for Fly projects #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcnc
approved these changes
Jun 7, 2024
pcnc
reviewed
Jun 10, 2024
docker/all-in-one/entrypoint.sh
Outdated
|
|
||
| # only extract a valid archive | ||
| if [[ $(tar -tzf $DELEGATED_ARCHIVE_PATH) ]]; then | ||
| # TODO: (tom) Only extract newer tar archives |
There was a problem hiding this comment.
Could we save the filemtime of the last extracted tarball in a persistent file and compare if current tarball filemtime is different?
There was a problem hiding this comment.
Have solved the time issue by adding a touch to the entryscript at build time
We could only be changing salt files, but this file will always definitively be in the archive.
tomashley
force-pushed
the
tom/delegated-init
branch
from
e89b132 to
ccac5b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature: Installs salt in the all-in-one Docker container used in Fly.io projects. Enables a delegated entry point for the container.
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.%