-
-
Notifications
You must be signed in to change notification settings - Fork 158
Adding head and count option on select(), insert(), update(), delete(), and rpc() #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d home and count option to select in PostgrestQueryBuilder
I have implemented |
@steve-chavez @kiwicopple @soedirgo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @dshukertjr, just one nit :)
Also, if you could add a simple test case in basic.ts
that would be great!
Co-authored-by: Bobbie Soedirgo <[email protected]>
I will work on adding the test cases now. |
I do have one concern about the result of |
Awesome work @dshukertjr, love the extensive tests :) Will merge this if it looks good @kiwicopple |
Since the last concern that I had with this PR is solved thanks to @kiwicopple , I think this PR is ready to be merged. |
🎉 This PR is included in version 0.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
It will add
head
andcount
option to allow querying row count.What is the current behavior?
Cannot get row count.
What is the new behavior?
Enable retrieving row count.
Related issues
#94