fix: rpc return type #394
Merged
fix: rpc return type #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPC return types aren't getting propagated properly. E.g. if a function returns `boolean`, the `data` will be typed as `boolean[]`. To fix this, we change PostgrestBuilder's type parameter to be the actual type of `data`, instead of the element type of `data` (which assumes `data` is always an array, which is incorrect). In doing so we effectively remove all usage of `PostgrestResponse` and `PostgrestMaybeSingleResponse`. We can stop exporting these on the next major version. This also fixes the behavior of `.returns<NewResult>()`, which was inconsistent with the documentation (i.e. `data` was typed as `NewResult[]` instead of `NewResult`).
steve-chavez
approved these changes
Feb 4, 2023
J0
approved these changes
Feb 5, 2023
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
oof, i was wondering why all my types got borked overnight. |
|
Sorry about that @natedunn - do you mind sharing how it's breaking your types? While we consider it a bug here we do want to make sure the fix isn't causing more issues at least. |
|
@soedirgo Yeah I can understand the mentality there, so no worries. There's not much to describe in terms of my issues. The PR description laid it out pretty well, so I knew what I had to change: This stopped working And this fixed the issue |
soedirgo
referenced
this pull request
in supabase/cli
May 30, 2023
|
I created this issue: #430 It is probably related to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #387.
RPC return types aren't getting propagated properly. E.g. if a function returns
boolean, thedatawill be typed asboolean[].To fix this, we change PostgrestBuilder's type parameter to be the actual type of
data, instead of the element type ofdata(which assumesdatais always an array, which is incorrect).In doing so we effectively remove all usage of
PostgrestResponseandPostgrestMaybeSingleResponse. We can stop exporting these on the next major version.This also fixes the behavior of
.returns<NewResult>(), which was inconsistent with the documentation (i.e.datawas typed asNewResult[]instead ofNewResult).