-
-
Notifications
You must be signed in to change notification settings - Fork 56
Add documentation #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 90.66% 92.25% +1.58%
==========================================
Files 22 22
Lines 911 930 +19
==========================================
+ Hits 826 858 +32
+ Misses 85 72 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lorn, thanks for putting this together!
.gitignore
Outdated
@@ -136,3 +136,6 @@ dmypy.json | |||
|
|||
# Poetry local config | |||
poetry.toml | |||
|
|||
# dummy test file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, didn't mean to leave that in. Good catch, reverted in 300a089
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.67%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
@J0 I tried deploying to RTD but I seem to not have enough permissions on this repo (it needs permissions to manage webhooks). Can you try? |
Weird, I'll look into getting you those permissions. One sec. Hmm seems like it was successfully deployed: https://postgrest-py.readthedocs.io/en/latest/api/filters.html lmk if this is still an issue! Btw, we should probably change the library namespace to |
@J0 the deployed version is pointing to my fork right now, not this repo. I did that because I couldn't get the config files just right so I needed to test first 😅 I'll move it here in a bit once I get the permissions. Or you could send me your readthedocs account name and I'll add you as a maintainer, and then you could set up the webhook (the webhook is to automatically deploy updated documentation when new commits are made) |
Alternatively, we can deploy docs to Github Pages intead of readthedocs. The domain name would then be |
This PR sets up documentation for the project using sphinx and furo, and adds a lot of missing type-hints/docstrings.
The documentation is by no means complete with this, but I think it's a start 😄
To view the documentation, checkout this branch and run
make html
in the docs directory.This PR also adds some code changes:
execute
method, instead of creating a newhttpx.Client
for every request(I forgot to make that a separate PR, sorry 😅 )