Skip to content

chore: update pre-commit #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2023
Merged

chore: update pre-commit #209

merged 4 commits into from
Feb 7, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Feb 7, 2023

see title

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 7, 2023

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.26 ⭐ 1.21 ⭐ -0.05 👍
Method Length 42.52 ⭐ 42.41 ⭐ -0.11 👍
Working memory 6.63 🙂 6.66 🙂 0.03 👎
Quality 83.17% 83.17% 0.00%
Other metrics Before After Change
Lines 990 987 -3
Changed files Quality Before Quality After Quality Change
postgrest/base_request_builder.py 84.74% ⭐ 84.79% ⭐ 0.05% 👍
postgrest/_async/request_builder.py 81.03% ⭐ 81.03% ⭐ 0.00%
postgrest/_sync/request_builder.py 81.08% ⭐ 81.08% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
postgrest/_async/request_builder.py AsyncRequestBuilder.upsert 0 ⭐ 60 ⭐ 13 😞 69.70% 🙂 Extract out complex expressions
postgrest/_sync/request_builder.py SyncRequestBuilder.upsert 0 ⭐ 60 ⭐ 13 😞 69.70% 🙂 Extract out complex expressions
postgrest/_async/request_builder.py AsyncRequestBuilder.insert 0 ⭐ 54 ⭐ 11 😞 73.95% 🙂 Extract out complex expressions
postgrest/_sync/request_builder.py SyncRequestBuilder.insert 0 ⭐ 54 ⭐ 11 😞 73.95% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Co-authored-by: Sourcery AI <>
@J0 J0 merged commit 4f451a3 into master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant