Skip to content

Add docker-compose setup for local development #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

sureshdsk
Copy link
Contributor

  • added docker-compose setup for local development
  • updated readme

@lqmanh
Copy link
Collaborator

lqmanh commented Oct 5, 2021

Thank you for your PR and sorry for my late reply.
I am just not sure if this is really necessary, as this docker-compose thing is related to Postgrest side. It is only useful if we use it in the testing pipeline.

@sureshdsk
Copy link
Contributor Author

I was trying to contribute to postgrest-py, Setting up local dev environment for development and testing was little bit hard. So I prepared this docker-compose setup as a first thing. It becomes so much easier to getstarted without fiddling around postgres and posgrest setup. I think we can also use this for running tests.

@lqmanh
Copy link
Collaborator

lqmanh commented Oct 6, 2021

I understand.
I may keep this PR open in case we really need it later, but cannot merge for now.

@lqmanh
Copy link
Collaborator

lqmanh commented Oct 22, 2021

@sureshdsk Thank you for your contribution. I think it's OK to merge this now.

@lqmanh lqmanh changed the title added docker-compose setup for local development Add docker-compose setup for local development Oct 22, 2021
@lqmanh lqmanh merged commit 1cb42a1 into supabase:master Oct 22, 2021
@sureshdsk
Copy link
Contributor Author

@lqmanh Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants