Skip to content

Migrate postgrest-py from pydantic v1 to v2. #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Migrate postgrest-py from pydantic v1 to v2. #276

merged 7 commits into from
Aug 4, 2023

Conversation

yuvanist
Copy link
Contributor

@yuvanist yuvanist commented Aug 3, 2023

What kind of change does this PR introduce?

Pydantic version update. All the existing test are passing.

@yuvanist
Copy link
Contributor Author

yuvanist commented Aug 3, 2023

@J0 Can you run workflow tests for this PR as well? And any expected time for this release once this PR gets merged?

@J0
Copy link
Contributor

J0 commented Aug 3, 2023

@yuvanist ETA probably tomorrow either before or after work. Thanks for the PR!

@yuvanist
Copy link
Contributor Author

yuvanist commented Aug 3, 2023

@J0 isort is failing in the workflow. I'll change and push in sometime.

@yuvanist
Copy link
Contributor Author

yuvanist commented Aug 4, 2023

@J0 isort is fixed. Please run the workflow once again.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (398610e) 91.63% compared to head (3e0dc10) 91.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          24       24           
  Lines        1183     1183           
=======================================
  Hits         1084     1084           
  Misses         99       99           
Files Changed Coverage Δ
postgrest/base_request_builder.py 78.03% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 merged commit 85ff406 into supabase:master Aug 4, 2023
J0 pushed a commit that referenced this pull request Aug 4, 2023
* Update package to pydantic 2.1

* Update poetry.lock

* Specify pydantic minor version

* isort fix

* Update poetry lock

* lock hash update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants