Skip to content

fix: query params are immutable when using order #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Jan 2, 2022

Fix #43

@leynier leynier added the bug Something isn't working label Jan 2, 2022
@leynier leynier requested a review from a team January 2, 2022 17:37
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 2, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.10%.

Quality metrics Before After Change
Complexity 1.27 ⭐ 1.27 ⭐ 0.00
Method Length 25.84 ⭐ 25.87 ⭐ 0.03 👎
Working memory 6.15 ⭐ 6.10 ⭐ -0.05 👍
Quality 86.72% 86.82% 0.10% 👍
Other metrics Before After Change
Lines 185 186 1
Changed files Quality Before Quality After Quality Change
postgrest_py/base_request_builder.py 86.72% ⭐ 86.82% ⭐ 0.10% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@dreinon dreinon merged commit d1254a6 into supabase:master Jan 2, 2022
@leynier leynier deleted the fix/query-params-are-immutable-when-using-order branch January 4, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: QueryParams are immutable when using order.
3 participants